Support changing the S3 Endpoint #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's also loads of linting and pre-commit checks that are failing, since they've never been enabled or enforced. I tried fixing them here, but it was getting out of hand, so I'm going to merge and fix later. The failing checkers are
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are multiple tests failing at the moment that this PR does not address. They are due to external changes changes in the Sentinel-2 STAC metadata.
This PR adds support for changing the S3 Endpoint to be used, by setting the environment variable
AWS_S3_ENDPOINT. This will allow changing the tests to use a localmotoserver instead of relying on external data sources for tests, which have changed and broken tests, and are liable to do so again in the future.See #470 and #521.
Closes: #470